[wp-trac] [WordPress Trac] #41463: Improve REST API tests that don't perform any assertions

[WordPress Trac]

#41463: Improve REST API tests that don't perform any assertions
--------------------------------------------+-----------------------------
 Reporter:  johnbillion                     |       Owner:  johnbillion
     Type:  enhancement                     |      Status:  accepted
 Priority:  normal                          |   Milestone:  Future Release
Component:  REST API                        |     Version:  4.7
 Severity:  normal                          |  Resolution:
 Keywords:  needs-unit-tests needs-refresh  |     Focuses:  rest-api
--------------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 In [changeset:"53921" 53921]:
 {{{
 #!CommitTicketReference repository="" revision="53921"
 Tests: Consistently skip tests for non-implemented methods in REST API
 test classes.

 WordPress core test suite uses PHPUnit's
 `beStrictAboutTestsThatDoNotTestAnything` option set to `true`, which
 marks a test as risky when no assertions are performed.

 REST API test classes have some empty tests for non-implemented methods
 because these test classes extend the abstract
 `WP_Test_REST_Controller_Testcase` class, which requires several methods
 to be implemented that don't necessarily make sense for all REST API
 routes.

 Some of these empty tests were already marked as skipped, but not in a
 consistent manner. Since skipping these tests is intentional for the time
 being, this commit aims to bring some consistency and adjust them all to
 be more accurately reported as skipped instead of risky.

 The skipping can be reconsidered in the future when the tests are either
 removed as unnecessary or updated to actually perform assertions related
 to their behavior.

 Follow-up to [40534], [41176], [41228].

 Props Mte90, tomepajk, johnbillion, zieladam, SergeyBiryukov.
 See #40538, #41463, #55652.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/41463#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform