[wp-trac] [WordPress Trac] #56033: PHP 8.2: explicitly declare all known properties

[WordPress Trac]

#56033: PHP 8.2: explicitly declare all known properties
--------------------------------------------+-----------------------------
 Reporter:  jrf                             |       Owner:  SergeyBiryukov
     Type:  task (blessed)                  |      Status:  accepted
 Priority:  normal                          |   Milestone:  6.1
Component:  General                         |     Version:
 Severity:  normal                          |  Resolution:
 Keywords:  has-patch php82 has-unit-tests  |     Focuses:
--------------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 In [changeset:"53916" 53916]:
 {{{
 #!CommitTicketReference repository="" revision="53916"
 Code Modernization: Remove dynamic properties in theme tests.

 Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2
 and are expected to become a fatal error in PHP 9.0.

 In this particular group of test files, the test classes contain a
 `set_up()` method which sets a few dynamic (not explicitly declared)
 properties.

 For those properties which were set using a function call or variable
 access, the property has been explicitly declared on the class now.

 For those properties which were set using a constant scalar expression and
 for which the value is not changed by any of the tests, the property
 setting has been removed in favor of declaring a class constant.

 Includes removing one unused dynamic property declaration:
 `$this->queries` in `Test_Block_Supports_Layout`, which appears to be a
 copy/paste from `Tests_Theme_wpThemeJsonResolver`.

 Follow-up to [40/tests], [260/tests], [598/tests], [50960], [52675],
 [53085], [53557], [53558], [53850], [53851], [53852], [53853], [53854],
 [53856].

 Props jrf.
 See #56033.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56033#comment:58>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform