[wp-trac] [WordPress Trac] #54662: The `test_get_terms_post_args_paging()` test performs no assertions

[WordPress Trac]

#54662: The `test_get_terms_post_args_paging()` test performs no assertions
-------------------------------+---------------------
 Reporter:  johnbillion        |       Owner:  (none)
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  6.1
Component:  REST API           |     Version:
 Severity:  normal             |  Resolution:
 Keywords:  reporter-feedback  |     Focuses:
-------------------------------+---------------------

Comment (by SergeyBiryukov):

 In [changeset:"53909" 53909]:
 {{{
 #!CommitTicketReference repository="" revision="53909"
 Tests: Assign created fixtures to the dedicated class properties in some
 test classes.

 This affects:
 * `WP_Test_REST_Categories_Controller`
 * `WP_Test_REST_Comments_Controller`
 * `WP_Test_REST_Tags_Controller`

 and brings consistency with:
 * `WP_Test_REST_Posts_Controller`
 * `WP_Test_REST_Users_Controller`

 These test classes were previously updated to improve performance by
 creating less fixtures and reusing them where possible. While the
 pagination tests for categories and comments still passed due to enough
 items being created, the pagination test for tags did not work as expected
 and did not perform any assertions due to trying to iterate over an empty
 array of results.

 This is now corrected by assigning the properties as intended and adding
 more assertions to the affected test.

 Follow-up to [46657].

 Props johnregan3, costdev, johnbillion.
 See #54662.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54662#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform