[wp-trac] [WordPress Trac] #54624: "Automated update failed" notice breaks Site Health styling

[WordPress Trac]

#54624: "Automated update failed" notice breaks Site Health styling
-----------------------------------------+-----------------------------
 Reporter:  johnjamesjacoby              |       Owner:  (none)
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  6.1
Component:  Upgrade/Install              |     Version:  5.2
 Severity:  normal                       |  Resolution:
 Keywords:  needs-patch has-screenshots  |     Focuses:  administration
-----------------------------------------+-----------------------------
Changes (by costdev):

 * milestone:  Awaiting Review => 6.1


Comment:

 A few notes on this:

 - This also affects the **Settings > Privacy** screen, as this shares the
 same design language as Site Health.
 - Looking at the **Settings > Privacy** screen, all notices that don't
 have the `inline` class are placed ''below'' the header.
   - The notices generated by `maintenance_nag()`, `update_nag()` and for
 multisite, `site_admin_notice()` all have the `inline` class. A solution
 could be to remove this class to create a consistent display.
 - When the currently selected Privacy page does not exist, the resulting
 notice on the **Settings > Privacy** screen is full width.
 - To reproduce this issue and test patches, you can display the
 maintenance nag by adding the following to a new plugin:

 {{{#!php
 <?php

 /**
  * Plugin Name: Show maintenance nag.
  * Description: Shows the maintenance nag.
  * Author:      WordPress Core Contributors
  * Author URI:  https://make.wordpress.org/core
  * License:     GPLv2 or later
  * Version:     1.0.0
  */

 add_action(
         'admin_init',
         function () {
                 global $upgrading;
                 $upgrading = true;
         }
 );
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54624#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform