[wp-trac] [WordPress Trac] #56369: Site health status widget unwanted margin

[WordPress Trac]

#56369: Site health status widget unwanted margin
-------------------------------------+-------------------------------------
 Reporter:  simkog                   |       Owner:  (none)
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  6.1
Component:  Site Health              |     Version:  5.3
 Severity:  minor                    |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, css,
  2nd-opinion                        |  administration
-------------------------------------+-------------------------------------

Comment (by costdev):

 Thanks @mukesh27!

 Just below the original position, the `margin-bottom` is set for `.site-
 health-progress-wrapper`.

 As the element in question shares both the `.health-check-widget-title-
 section` and `.site-health-progress-wrapper` classes, attempting to set
 `margin-bottom` on `.health-check-widget-title-section` will be
 immediately overwritten just a few lines down.

 The options I saw available were:
 1. Keep the `.health-check-widget-title-section` in place and add
 `!important` to the `margin-bottom` rule - a no-no.
 2. Set the `margin-bottom` for `.health-check-widget-title-section`
 further down.

 Rather than have two styling blocks for `.health-check-widget-title-
 section`, I felt it best to keep these together.

 Upon reviewing further down the file, I saw this comment:

 {{{#!css
 /* Styling unique to the dashboard widget. */
 }}}

 Since the current styling for `.health-check-widget-title-section` should
 have been in this section anyway, I felt it best to move this into the
 correct section and add the new `margin-bottom` rule required for this
 patch.

 In testing, I don't believe that moving the original styling block
 introduces a regression. However, if in testing by others, a regression is
 revealed, I'm happy to revise the patch.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56369#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform