[wp-trac] [WordPress Trac] #18609: term_id collisions possible with InnoDB tables and global_terms_enabled

[WordPress Trac]

#18609: term_id collisions possible with InnoDB tables and global_terms_enabled
-------------------------------------+------------------------------
 Reporter:  andrew_l                 |       Owner:  (none)
     Type:  defect (bug)             |      Status:  assigned
 Priority:  lowest                   |   Milestone:  Awaiting Review
Component:  Taxonomy                 |     Version:  3.2.1
 Severity:  major                    |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  multisite
-------------------------------------+------------------------------
Changes (by peterwilsoncc):

 * keywords:  has-patch needs-testing needs-refresh => has-patch needs-
               testing


Comment:

 The only time I've heard of someone outside of this ticket using global
 terms was to set up truly global terms: meaning each site used the
 network's terms table and displayed the same list of terms on all sites.

 I think the KISS approach of the original patch is the best fix for this.
 I've refreshed it in [attachment:"18609.diff"] and continued to use an
 `UPDATE` if the new ID is unlikely to modify the auto increment value.

 > ... I wouldn't expect it to be fixed in MySQL ever.

 Turns out it was fixed in 8.0 :)

 Viably, I think if code similar to the patch isn't committed any time soon
 this ticket ought to be closed `wontfix`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/18609#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform