[wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0
WordPress Trac
noreply at wordpress.org
Tue Apr 26 14:54:52 UTC 2022
#55327: PHP 8.0: improvements to allow for named parameters in WP 6.0
-----------------------------+---------------------
Reporter: peterwilsoncc | Owner: (none)
Type: task (blessed) | Status: new
Priority: normal | Milestone: 6.0
Component: General | Version:
Severity: normal | Resolution:
Keywords: php80 has-patch | Focuses:
-----------------------------+---------------------
Comment (by SergeyBiryukov):
In [changeset:"53283" 53283]:
{{{
#!CommitTicketReference repository="" revision="53283"
Code Modernization: Rename parameters that use reserved keywords in `wp-
includes/class.wp-scripts.php`.
While using reserved PHP keywords as parameter name labels is allowed, in
the context of function calls using named parameters in PHP 8.0+, this
will easily lead to confusion. To avoid that, it is recommended not to use
reserved keywords as function parameter names.
This commit renames the `$echo` parameter to `$display` in `WP_Scripts`
class methods.
Follow-up to [52946], [52996], [52997], [52998], [53003], [53014],
[53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185],
[53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220],
[53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245],
[53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274],
[53275], [53276], [53277], [53281].
Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #55327.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:57>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list