[wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0

[WordPress Trac]

#55327: PHP 8.0: improvements to allow for named parameters in WP 6.0
-----------------------------+---------------------
 Reporter:  peterwilsoncc    |       Owner:  (none)
     Type:  task (blessed)   |      Status:  new
 Priority:  normal           |   Milestone:  6.0
Component:  General          |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  php80 has-patch  |     Focuses:
-----------------------------+---------------------

Comment (by SergeyBiryukov):

 In [changeset:"53269" 53269]:
 {{{
 #!CommitTicketReference repository="" revision="53269"
 Code Modernization: Rename parameters that use reserved keywords in `wp-
 includes/class-wp-embed.php`.

 While using reserved PHP keywords as parameter name labels is allowed, in
 the context of function calls using named parameters in PHP 8.0+, this
 will easily lead to confusion. To avoid that, it is recommended not to use
 reserved keywords as function parameter names.

 This commit renames the `$match` parameter to `$matches` in
 `WP_Embed::autoembed_callback()`.

 Follow-up to [52946], [52996], [52997], [52998], [53003], [53014],
 [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185],
 [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220],
 [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245],
 [53246], [53257].

 Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
 See #55327.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:47>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform