[wp-trac] [WordPress Trac] #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js

WordPress Trac noreply at wordpress.org
Mon Apr 11 23:29:54 UTC 2022


#55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js
-------------------------------------+-------------------------------------
 Reporter:  SergeyBiryukov           |       Owner:  joedolson
     Type:  enhancement              |      Status:  reopened
 Priority:  normal                   |   Milestone:  6.0
Component:  Administration           |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  accessibility,
  commit                             |  javascript
-------------------------------------+-------------------------------------
Changes (by SergeyBiryukov):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Thanks everyone!

 I don't see a reason for `'data' => $message` to remain, it was only added
 five months ago in [52170] and never documented anywhere, so should not
 affect backward compatibility. The duplication might also cause confusion
 later.

 I think the test just needs to be updated to check the
 `supplemental->notice` property instead, see [attachment:"55078.4.diff"].
 With this change, the tests pass as expected.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55078#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list