[wp-trac] [WordPress Trac] #30154: Improve Media Modal UI at small-screen sizes: Redux

WordPress Trac noreply at wordpress.org
Thu Apr 7 20:58:24 UTC 2022


#30154: Improve Media Modal UI at small-screen sizes: Redux
-------------------------------------------------+-------------------------
 Reporter:  mor10                                |       Owner:  joedolson
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  6.0
Component:  Media                                |     Version:  4.0
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-patch needs-      |     Focuses:  ui,
  testing                                        |  javascript
-------------------------------------------------+-------------------------
Changes (by joedolson):

 * keywords:  good-first-bug has-patch needs-refresh needs-testing => good-
     first-bug has-patch needs-testing


Comment:

 It seems like the bulk of the content of this patch are invalid changes;
 most changes are white space modifications, which make it pretty difficult
 to figure out what was changed. But it appears that the only changes made
 were the addition of the 'imgedit-crop' class to hide the cropping
 controls.

 As of my testing today, cropping does work on mobile; though it's
 difficult to use due to the layout problems this ticket documents. Given
 that, I think that only the CSS changes are still relevant here.

 - Adjust the max-width in CSS to match other break points.
 - moved CSS changes from `/wp-includes/css/media-views.css` to `/wp-
 admin/css/media.css`, where other related settings CSS is already.

 At this point, I think this is a pretty straightforward change, and well
 worth committing.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/30154#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list