[wp-trac] [WordPress Trac] #45021: Media: Gallery modal has wrong focus and image detail

[WordPress Trac]

#45021: Media: Gallery modal has wrong focus and image detail
-------------------------------------+-------------------------------------
 Reporter:  joyously                 |       Owner:  joedolson
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  6.0
Component:  Media                    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots needs-   |     Focuses:  accessibility,
  patch                              |  javascript
-------------------------------------+-------------------------------------

Comment (by joedolson):

 I took a close look at this, and in my testing I think there's some lack
 of clarity, but it isn't focus issues. A lot of the focus states were
 changed when the media library was adapted to use a standardized tab UI in
 https://core.trac.wordpress.org/ticket/47149, so much of this is possibly
 obsolete.

 1) Add Media > Focus is set to the Add Media dialog.

 There's no visible focus, because it's the entire dialog that has focus.
 This is fine.

 2) Create Gallery > Search focused.

 I wasn't able to reproduce this; in my testing, after clicking 'Create
 Gallery', the next tab moved focus to the Media Library tab, then within
 the tab.

 3) Click an image, then Create Gallery > Selected image is focused.

 The selected image is not focused, though the 'image selected' state is
 very similar to the 'image focused' state. There isn't a screenshot
 showing this state, so this may have changed since the original report;
 but perhaps the 'selected image' design should be better differentiated
 from the 'focused' design? They aren't the same; focused has a shadow/blur
 outline, selected is a solid outline, but they are similar.

 4) If multiple images selected in Edit Gallery / Create Gallery, then
 'Create a New Gallery' clicked, 'Cancel Gallery' is focused.

 At this point, I'm getting 'Edit Gallery' as the focus, which represents
 the current view; I think that's reasonable.

 Most of the differences above stem from the changes following the Media
 Library changes stemming from
 https://core.trac.wordpress.org/ticket/47149.

 5) On cancelling the creation of a gallery, the selected images are still
 selected in Add Media.

 This seems like a legitimate problem, still - though it's not focus
 related. We do have two separate controls: one to clear the selection, and
 one to cancel creation of the gallery. They are technically different
 actions, but I think it's very reasonable that a user would expect
 cancelling the creation of a gallery to also clear their selection. I
 think we should consider that change. I'm not sure what the use case might
 be for "cancel creating this gallery, but retain the selected images".

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45021#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform