[wp-trac] [WordPress Trac] #54177: Add visibility to test class methods

[WordPress Trac]

#54177: Add visibility to test class methods
--------------------------------------+-------------------------------
 Reporter:  costdev                   |       Owner:  (none)
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  Future Release
Component:  Build/Test Tools          |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  coding-standards
--------------------------------------+-------------------------------

Comment (by costdev):

 > No worries. We'll sort that out when actioning the
 [https://make.wordpress.org/core/2020/03/20/updating-the-coding-standards-
 for-modern-php/ WPCS update for modern PHP], though that does mean that
 the sniffs won't be moved (from `Extra` to `Core`) until that's all
 sorted. See the "Visibility should always be declared" section in that dev
 note for more information.

 Great, thanks for that!

 > Sounds good to me. Might be an idea to post a link to this ticket in
 #53359 for visibility.

 Done!

 > As this is potentially a huge patch, it might make for easier reviewing
 and quicker commits to submit this in chunks, `wp-includes`, `wp-admin`,
 `tests/phpunit/tests` etc.

 No problem - I'll split this into separate PRs for easier reviewing.

 > Absolutely, but please be careful not to break BC. When in doubt, always
 use `public`.

 Noted!

 > Have you got a branch somewhere in a fork with these changes ? I'd
 recommend a few small tweaks and can push those up to your fork if you
 like.

 See [https://github.com/costdev/PHP_CodeSniffer/commits/WP-One-Time-Auto-
 Fixes here].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54177#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform