[wp-trac] [WordPress Trac] #54256: Properly escape url and attributes in wp-admin/themes.php
WordPress Trac
noreply at wordpress.org
Wed Oct 13 12:38:20 UTC 2021
#54256: Properly escape url and attributes in wp-admin/themes.php
--------------------------+-------------------------------
Reporter: sabbirshouvo | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Themes | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses: coding-standards
--------------------------+-------------------------------
Comment (by sabbirshouvo):
Replying to [comment:2 audrasjb]:
> I think most of these variables don't need to be escaped, since they are
generated by WordPress itself and can't be edited in any way.
>
> (removing `trunk` version)
Thanks for you feedback. I want to mention about few cases where same
attributes are escaped and some are not in the same file.
/wp-admin/themes.php
Please check line: `535,548,555,567,870,894,907,913`
if these needs attribute escaping then why not line `1120,1129,1140` ?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/54256#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list