[wp-trac] [WordPress Trac] #54418: Admin menu sidebar: Customizer menu item is not visible when a classic theme is active

[WordPress Trac]

#54418: Admin menu sidebar: Customizer menu item is not visible when a classic
theme is active
------------------------------+---------------------
 Reporter:  poena             |       Owner:  (none)
     Type:  defect (bug)      |      Status:  new
 Priority:  high              |   Milestone:  5.9
Component:  Administration    |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  ui
------------------------------+---------------------
Changes (by hellofromTonya):

 * keywords:  has-patch => has-patch commit


Comment:

 == What's so special about position 7 in the Appearance sidebar menu?

 Investigation:

 * Confirmed the `Customize` menu item is being added at position 7 after
 [52069]. That code works.
 * Changed the position to 8, which also works.
 * With 5.8.2, changed the Customize menu position from 6 to 7. Nope, it
 does not display.
 * With 5.8.2, changed the Themes menu position from 5 to 7. Nope, it does
 not display either. What?!

 Conclusions:

 * The problem is not due to [52069].
 * Something in the codebase is removing (not hiding, literally removing)
 any Appearance submenu item from position 7.
 * Finding it will likely take time and patience to go down the rabbit
 hole.
 * I think this is a separate issue that deserves its own ticket.

 == What about this ticket and patch?

 Themes without a `/block-templates/index.html` file show the Customizer
 menu item by default. Any plugin or theme that ''expects'' it in that
 position (for customization, relocating, or removal) will be impacted with
 this position change. That can be considered a breaking change.

 I think restoring the original position makes sense. Marking for `commit`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54418#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform