[wp-trac] [WordPress Trac] #45537: Allow block editor to be used on the posts page using filters

WordPress Trac noreply at wordpress.org
Tue May 18 21:52:57 UTC 2021


#45537: Allow block editor to be used on the posts page using filters
-----------------------------+-----------------------------
 Reporter:  cameronjonesweb  |       Owner:  SergeyBiryukov
     Type:  defect (bug)     |      Status:  reviewing
 Priority:  normal           |   Milestone:  5.8
Component:  Editor           |     Version:  5.0
 Severity:  minor            |  Resolution:
 Keywords:  has-patch        |     Focuses:
-----------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => reviewing
 * milestone:  Future Release => 5.8


Comment:

 Thanks for the PR! This looks good to me at a glance, I would suggest a
 few minor changes:
 * It looks like unit tests currently fail due to an extra comma on line
 2687 inside the `sprintf()` call. The PHP compatibility check displays a
 notice: "Trailing comma's are not allowed in function calls in PHP 7.2 or
 earlier".
 * The function name should probably start with an underscore, for
 consistency with `_wp_posts_page_notice()`.
 * Instead of always hooking the function to `admin_notices` and then
 checking the post ID inside the function, let's perform that check in `wp-
 admin/edit-form-blocks.php`, for consistency with how it's done for the
 classic editor in `wp-admin/edit-form-advanced.php`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45537#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list