[wp-trac] [WordPress Trac] #53206: Fatal error in Site Health test_check_wp_filesystem_method when using other FS_METHOD than direct

[WordPress Trac]

#53206: Fatal error in Site Health test_check_wp_filesystem_method when using other
FS_METHOD than direct
--------------------------+---------------------
 Reporter:  lakrisgubben  |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  5.8
Component:  Site Health   |     Version:  5.6
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+---------------------

Comment (by lakrisgubben):

 I tried searching the WP codebase to see if there was any precedent for
 this kind of situation (where an admin function/file was required when not
 in admin and that function depended on another file only loaded in admin)
 but I couldn't find anything . Do you @SergeyBiryukov or someone else that
 has a deeper knowledge of the codebase than me know if any such precedent
 exists?

 I can see merit in both ways of doing it. Keeping it like in the PR might
 be more clear since it's "closer" to where the issue arose, but moving it
 to the {{{request_filesystem_credentials}}} function will alleviate any
 issues going forward if that function would be used outside of an admin
 context in another place. No strong opinion about it though. :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53206#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform