[wp-trac] [WordPress Trac] #15134: WordPress should not try to remove theme's or plugin's directory recursively if the directory is a symlink

[WordPress Trac]

#15134: WordPress should not try to remove theme's or plugin's directory
recursively if the directory is a symlink
---------------------------------+-----------------------------
 Reporter:  vladimir_kolesnikov  |       Owner:  pbiron
     Type:  defect (bug)         |      Status:  accepted
 Priority:  normal               |   Milestone:  Future Release
Component:  Upgrade/Install      |     Version:
 Severity:  major                |  Resolution:
 Keywords:  has-patch            |     Focuses:
---------------------------------+-----------------------------

Comment (by pbiron):

 [attachment:"15134.2.diff"] refreshes the patch so that it applies
 cleanly.

 The refresh also incorporates the Windows-specific changes to
 [https://developer.wordpress.org/reference/classes/wp_filesystem_direct/delete/
 WP_Filesystem_Direct::delete()] from
 [https://core.trac.wordpress.org/attachment/ticket/36710/36710.6.diff
 36710.diff].

 Now, the only difference between [attachment:"15134.2.diff"] and
 36710.diff is 15134.2.diff has the additional check in
 [https://developer.wordpress.org/reference/classes/wp_upgrader/clear_destination/
 WP_Upgrader::clear_destination()].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/15134#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform