[wp-trac] [WordPress Trac] #53121: wp_get_image_mime() - something weird going on

WordPress Trac noreply at wordpress.org
Sat May 1 01:58:35 UTC 2021


#53121: wp_get_image_mime() - something weird going on
--------------------------+------------------------------
 Reporter:  jrf           |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Media         |     Version:  4.8
 Severity:  minor         |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------------------

Comment (by jrf):

 > So now I'm confused.

 @joemcgill Ha! We're doing a good job confusing each other 😂

 >  If getimagesize() always works, then how is this test ever being
 skipped? Wouldn't the second condition of that if statement, !
 function_exists( 'getimagesize' ) always be falsey and cause the test to
 run?

 That was exactly why I opened the issue. Reading it back now, I definitely
 didn't explain it well enough, but yes, the test will always run.

 I was looking to transform the condition to `@requires` tags or to remove
 it and with the condition as was I couldn't get the test to fail.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53121#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list