[wp-trac] [WordPress Trac] #52826: New wp_getimagesize() causing unexpected failures

WordPress Trac noreply at wordpress.org
Thu Mar 18 14:32:04 UTC 2021


#52826: New wp_getimagesize() causing unexpected failures
--------------------------+---------------------
 Reporter:  terriann      |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  5.7.1
Component:  Media         |     Version:  5.7
 Severity:  critical      |  Resolution:
 Keywords:                |     Focuses:
--------------------------+---------------------
Changes (by Mista-Flo):

 * keywords:  has-patch =>


Comment:

 Hi @terriann, thanks for your patch!

 However, there is just a small issue with it, if we refer to the
 `getimagesize` function, the
  hint type is `array &$image_info = null`, so we should keep consistency
 and use the same hint.

 Furthermore, it doesn't require to add extra condition to check if it's
 null or not.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52826#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list