[wp-trac] [WordPress Trac] #53386: Multisite is_super_admin call during app password validation can lead to infinite loop

WordPress Trac noreply at wordpress.org
Fri Jun 18 00:57:03 UTC 2021


#53386: Multisite is_super_admin call during app password validation can lead to
infinite loop
----------------------------------------+-----------------------
 Reporter:  chrisvanpatten              |       Owner:  (none)
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  5.9
Component:  Users                       |     Version:  5.6
 Severity:  normal                      |  Resolution:
 Keywords:  needs-unit-tests has-patch  |     Focuses:  rest-api
----------------------------------------+-----------------------

Comment (by peterwilsoncc):

 In the [https://github.com/WordPress/wordpress-develop/pull/1391 linked
 pull request]:

 * always use `get_userdata()` within `is_super_admin()` following #28020
 * it still needs unit tests, I couldn't get them to loop in multisite
 prior to the patch being applied using the filter above
 * manual tests suggest the patch works but I'd rather not risk a merge
 without tests

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53386#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list