[wp-trac] [WordPress Trac] #49264: Redesign the Privacy Settings page (includes Privacy Policy Guide)

[WordPress Trac]

#49264: Redesign the Privacy Settings page (includes Privacy Policy Guide)
-------------------------------------+-------------------------------------
 Reporter:  xkon                     |       Owner:  xkon
     Type:  enhancement              |      Status:  reviewing
 Priority:  normal                   |   Milestone:  5.7
Component:  Privacy                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, accessibility,
  has-screenshots                    |  administration
-------------------------------------+-------------------------------------

Comment (by paaljoachim):

 It was somewhat difficult getting the testing commands correct.

 1. Applied patch from trac ticket.

 {{{
 npm run grunt patch:49264
 }}}

 Then

 {{{
 npm run patch https://github.com/WordPress/wordpress-develop/pull/957
 }}}

 I muddled a bit back on forth. Do please update the above commands so that
 I can get it right another time. Thanks.

 -----

 The testing.

 EDIT: **There is a lot of feedback here. Which means you will need to
 focus on the main things that is to be tested, and other things could be
 for a followup etc later.**


 1.Apply the patch provided from the Github PR.
 **->Done.**

 2.Install WooCommerce for example (to have an extra policy text).
 **->Done.**

 3.Make sure TwentyTwentyOne is selected (to have an extra policy text).
 **->Done.**

 **Step 1 Settings tab:**

 1.Go to Settings -> Privacy (Settings Tab is selected by default), you
 should see the new design as shown in 49264.5_preview.gif
 -> Yes. What I see is very similar. I have just not yet pressed the Create
 button to
 "Create a new Privacy Policy Page"
 Below it I see the
 "Change your Privacy Policy page" = should be a capital P. A drop down
 next to it with various options. Most of the options are from WooCommerce.
 I am able to select the various options. I have not yet clicked "Create"
 or "Use this Page" buttons.


 2.The Settings options ( Create a new Privacy Policy Page / Change your
 Privacy Policy page ) should be properly working.


 -> Clicking the "Create" button. The screen jumped to a new(?) Privacy
 Policy page. With various information added to the Classic Editor. So that
 I will need to if using Gutenberg click each area and then click Convert
 to blocks. I went ahead and converted all of these to blocks. At the top
 is a notification that says:
 "Need help putting together your new Privacy Policy page? Check out our
 guide for recommendations on what content to include, along with policies
 suggested by your plugins and theme." Here it would be nice if the
 sentence began with a Do you....then the rest of the information. Such as:
 Do you need help putting together....

 A link to: "View Privacy Policy Guide" To open it in a new tab I would
 have to right click and select to open it in a new tab. Ahhh the link
 brings me back to the Settings -> Privacy -> Policy Guide tabbed area.
 That was not clear. I thought it was to an external site.

 In a new tab I am at the Policy Guide. Clicking the Settings tab. I was
 expecting to see a mention that I have already created a Privacy Policy
 Page. As I can create a bunch of Policy pages. I notice these show up in
 the drop down right below.

 I selected in the drop down one of the Privacy Policy pages that I made,
 and clicked "Use This Page". A notification showed up just above the
 Privacy Settings saying: "Privacy Policy page updated successfully." =
 Remember capital P in Page. (Or change "
 Create a new Privacy Policy Page" Page = P to a smaller case.)

 Selected Cart in the drop down. Clicked "Use This Page" Notification says:
 "Privacy Policy page setting updated successfully. Remember to update your
 menus!"

 --

 Bottom line for the Settings -> Privacy Settings.
 Creating a new Privacy Policy Page/page works well!
 Changing the Privacy Policy page/Page works well!

 -
 -

 3.The links on the Settings page are going to the correct Policy page
 (Edit or preview links ) are redirecting to the correct Policy page that
 is set.

 --> Yes. Clicking Edit or view goes to the Privacy Policy page that is set
 in the drop down further below.

 4.The link Check out our Privacy Policy guide should point to the Policy
 Guide tab.

 --> Yes. Clicking "Check out our Privacy Policy guide" goes to the Policy
 Guide tab.


 **Step 2 Policy Guide tab:**

 5.Go to Policy Guide tab, the design should again be similar to the
 preview mentioned above.

 --> Yes. The design is similar to the preview mentioned above.

 6.The accordions should be accessible by keyboard as well (similar to Site
 Health).

 --> I am able to tab my way through each accordion, and see the blue
 outline of each.
 **I am though not able to open these up. I click the arrows in the
 accordions but nothing happens.**

 7.The Privacy Policy Guide, only contains the "guide" section of our older
 text.

 --> Ok.

 8.The WordPress under Policies only contains all of the Core suggested
 policy texts.

 --> Ok.

 After this it gets kinda hazy. Perhaps it has to do with the contents
 inside the accordions.
 This I am not seeing:
 "Press the Copy suggested policy text to clipboard button to copy the
 suggested text."

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49264#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform