[wp-trac] [WordPress Trac] #52343: Site Health Page: Inactive theme message is inconsistent

WordPress Trac noreply at wordpress.org
Thu Jan 28 18:07:48 UTC 2021


#52343: Site Health Page: Inactive theme message is inconsistent
------------------------------+------------------------------
 Reporter:  subrataemfluence  |       Owner:  (none)
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Site Health       |     Version:  5.6
 Severity:  normal            |  Resolution:
 Keywords:  2nd-opinion       |     Focuses:  administration
------------------------------+------------------------------

Comment (by joyously):

 The way that the check for the default theme is done needs to change.
 Currently, it is using the `WP_DEFAULT_THEME` constant as the theme to
 find. But core uses that constant as the starting place to find the
 default theme:
 {{{
 // If WP_DEFAULT_THEME doesn't exist, fall back to the latest core default
 theme.
 $default_theme = wp_get_theme( WP_DEFAULT_THEME );
 if ( ! $default_theme->exists() ) {
         $default_theme = WP_Theme::get_core_default_theme();
 }
 }}}

 So Site Health needs to call `WP_Theme::get_core_default_theme()` instead
 of simply checking the constant.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52343#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list