[wp-trac] [WordPress Trac] #51839: When get_feed_permastruct() return false, get_feed_link() return incorrect non feed url
WordPress Trac
noreply at wordpress.org
Thu Feb 11 05:05:30 UTC 2021
#51839: When get_feed_permastruct() return false, get_feed_link() return incorrect
non feed url
--------------------------------------+---------------------
Reporter: hauvong | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.7
Component: Feeds | Version: 5.5
Severity: minor | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+---------------------
Changes (by peterwilsoncc):
* keywords: has-patch needs-unit-tests => has-patch has-unit-tests
Comment:
In [attachment:"51839.2.diff"] :
* Same change to `get_feed_link()` as earlier, using a truthy check rather
than strict check
* Unit tests x3 sets
- plain permalinks
- pretty links without a plain text prefix
- pretty links with a plain text prefix
All looks to be passing but another set of eyes would be ideal.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/51839#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list