[wp-trac] [WordPress Trac] #53668: Generated images for one file can be overwritten by another with the same name when mapping mime types for generated images

WordPress Trac noreply at wordpress.org
Thu Aug 12 15:09:17 UTC 2021


#53668: Generated images for one file can be overwritten by another with the same
name when mapping mime types for generated images
-------------------------------------+---------------------
 Reporter:  ianmjones                |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  5.8.1
Component:  Media                    |     Version:  5.8
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+---------------------

Comment (by antpb):

 This was discussed in the recent Media component meeting and it was
 determined that due to the nature of this bug, the proposed patch needs to
 have a helper function due to the dependent logic running multiple times.

 This helper function is necessary to fix the issue correctly and no other
 temporary fix is currently available without adding a new function in
 5.8.X.

 as @joedolson mentioned in the meeting

 `Given that the new function will only be used in a case that only exists
 due to the new filter, it seems like it shouldn’t have broad unintended
 consequences.`

 Some feedback also given in the meeting is that the doc block should
 include a @private tag to indicate that this is not encouraged to be used
 outside of Core functions.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53668#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list