[wp-trac] [WordPress Trac] #50913: PHP 8.0: various compatibility fixes

[WordPress Trac]

#50913: PHP 8.0: various compatibility fixes
-------------------------------------------+-------------------------------
 Reporter:  jrf                            |       Owner:  SergeyBiryukov
     Type:  task (blessed)                 |      Status:  reviewing
 Priority:  normal                         |   Milestone:  5.6
Component:  General                        |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  php8 has-patch needs-dev-note  |     Focuses:  coding-standards
-------------------------------------------+-------------------------------

Comment (by azaozz):

 Replying to [comment:16 andraganescu]:
 > ...the new [https://wiki.php.net/rfc/string_to_number_comparison Saner
 string to number comparisons] makes it so that `"" < 0 === true`

 Ugh, thinking that's going to be another big "back-compat-fail" thing in
 PHP 8.0 :(

 > Question: should I open a PR against this ticket for such findings as
 well or is this ticket for more holistic fixes?

 Thinking a PR would be good, at least for "documentation purposes". Then
 gather all the "findings" and publish them on make/core. I'm sure the PHP
 team will publish a "Migration guide" at some point but the sooner plugins
 authors know what to look for when checking their plugins, the better :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50913#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform