[wp-trac] [WordPress Trac] #50683: Parse content for shortcodes instead of using regex

WordPress Trac noreply at wordpress.org
Tue Oct 20 18:54:03 UTC 2020


#50683: Parse content for shortcodes instead of using regex
-------------------------------------------------+-------------------------
 Reporter:  cfinke                               |       Owner:
                                                 |  SergeyBiryukov
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.7
Component:  Shortcodes                           |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests early       |     Focuses:
  needs-testing                                  |
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 Just noting that this looks great, but needs some minor cleanup to adjust
 documentation per the standards, move the test examples to the
 `tests/phpunit/data/` directory, remove debugging, etc.

 Additionally, the `Shortcode_Parser` should probably be
 `WP_Shortcode_Parser` to avoid conflicts, and should be located in its own
 file, `wp-includes/class-wp-shortcode-parser.php`, per the coding
 standards.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50683#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list