[wp-trac] [WordPress Trac] #38074: comments_template needs a filter for $top_level_args

WordPress Trac noreply at wordpress.org
Thu Oct 1 19:44:11 UTC 2020


#38074: comments_template needs a filter for $top_level_args
-------------------------------------------------+-------------------------
 Reporter:  thomaslhotta                         |       Owner:
                                                 |  SergeyBiryukov
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.6
Component:  Comments                             |     Version:  4.5
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-dev-   |     Focuses:
  note needs-unit-tests needs-refresh            |
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):

 * keywords:  has-patch needs-testing => has-patch needs-testing needs-dev-
     note needs-unit-tests needs-refresh


Comment:

 Though it's a small patch, it would benefit from a refresh against `src`.

 A new filter is being added. Needs a call-out in the Misc Dev Note.

 Suggestion: consider guarding the returned filtered value to validate that
 it is the data type and value range expected. Adding `needs-unit-tests`
 for additional test case scenarios to validate the returned filtered
 value.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/38074#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list