[wp-trac] [WordPress Trac] #37134: Allow filtering of safecss_filter_attr

WordPress Trac noreply at wordpress.org
Wed May 20 22:46:48 UTC 2020


#37134: Allow filtering of safecss_filter_attr
---------------------------------------------+-----------------------------
 Reporter:  paulschreiber                    |       Owner:
                                             |  adamsilverstein
     Type:  enhancement                      |      Status:  accepted
 Priority:  normal                           |   Milestone:  Awaiting
                                             |  Review
Component:  Formatting                       |     Version:  4.6
 Severity:  normal                           |  Resolution:
 Keywords:  kses has-patch needs-unit-tests  |     Focuses:
---------------------------------------------+-----------------------------

Comment (by adamsilverstein):

 [attachment:"37134.6.diff"] adds some unit tests that verify the filter
 works correctly.

 I included the test cases @joehoyle added in #24157
 (https://core.trac.wordpress.org/attachment/ticket/24157/kses.diff) and
 verified both that these are cleared currently and that the filter can be
 used to enable these cases.

 Adding a filter unblocks these specific use cases without changing the
 current behavior.

 @azaozz does this look ok to you, or do you think we should go further and
 change the regex itself?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/37134#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list