[wp-trac] [WordPress Trac] #48814: Comment marked as spam displays poorly in mobile view

WordPress Trac noreply at wordpress.org
Tue May 19 20:25:52 UTC 2020


#48814: Comment marked as spam displays poorly in mobile view
-------------------------------------------------+-------------------------
 Reporter:  jeremyfelt                           |       Owner:
                                                 |  adamsilverstein
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  5.4
Component:  Comments                             |     Version:
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  good-first-bug has-patch has-        |     Focuses:  ui, css
  screenshots commit                             |
-------------------------------------------------+-------------------------

Comment (by johnjamesjacoby):

 Apologies, but unfortunately this minor change has caused a somewhat major
 regression in [https://github.com/sugarcalendar/lite/issues/42 one of my
 plugins].

 I can fix this for my users, but I am concerned about unreported breakage
 in other plugins due to the relatively reduced footprint of mobile users
 attempting to manage their content within WordPress Admin.

 ----

 The `display: block;` that was removed in r47340 was necessary to override
 the default `display: table-cell` styling.

 `table-cell` and `width: auto !important` will not allow for the targeted
 `td`s to occupy the full-width of the parent element.

 It is also why this rule...

 {{{
 .wp-list-table .is-expanded td:not(.hidden)
 }}}

 ...still requires `display: block !important;`. Otherwise, it would also
 unintentionally risk not being full-width.

 ----

 In this rule, WordPress avoids applying styling to `tr` elements using
 `:not()` - like:

 {{{
 .wp-list-table tr:not(.inline-edit-row):not(.no-items) td:not(.check-
 column)
 }}}

 I believe the non-breaking change here would have been to leave the
 `display: block;` it and also avoid styling `unspam` columns, like:

 {{{
 .wp-list-table tr:not(.inline-edit-row):not(.no-items):not(.unspam) td:not
 (.check-column)
 }}}

 Will leave this up to the contributors here to decide how best to proceed.
 Sorry again, and thanks for looking & understanding. 💙

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48814#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list