[wp-trac] [WordPress Trac] #50159: Simplepie 1.5.5 - code review and modifications - fix SimplePie cache bug

WordPress Trac noreply at wordpress.org
Thu May 14 08:22:05 UTC 2020


#50159: Simplepie 1.5.5 - code review and modifications - fix SimplePie cache bug
--------------------------+------------------------------
 Reporter:  arena         |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Feeds         |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------------------

Comment (by SergeyBiryukov):

 Replying to [ticket:50159 arena]:
 > * deprecating files and classes
 > * renaming files and classes for code consistancy
 > * adopting extended wp class registering available since SimplePie 1.3.3
 (SimplePie_Registry)

 Thanks for the patch! I don't think any of the existing files should be
 deprecated or renamed here. Consistency is good in general, but doesn't
 seem like a strong enough reason. Renaming these files would make it
 harder to replace SimplePie with another library in the future should the
 need arise.

 In any case, with the file renaming and actual changes in one patch, it's
 hard to see what's going on. For easier review, it would be helpful to
 only focus on code changes to the existing files in this ticket.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50159#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list