[wp-trac] [WordPress Trac] #37011: Don’t link custom logo if it’s displayed on the front page

WordPress Trac noreply at wordpress.org
Sun Jun 14 09:52:41 UTC 2020


#37011: Don’t link custom logo if it’s displayed on the front page
-------------------------------------------------+-------------------------
 Reporter:  FlorianBrinkmann                     |       Owner:  joedolson
     Type:  enhancement                          |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.5
Component:  Themes                               |     Version:  4.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-dev-note 2nd-        |     Focuses:
  opinion                                        |  accessibility
-------------------------------------------------+-------------------------
Description changed by SergeyBiryukov:

Old description:

> Hey!
>
> I have looked at the `get_custom_logo()` function recently and noticed
> that the logo is linked to home even if it is displayed on the front
> page.
>
> Wouldn’t it make sense to only link the logo if it is not displayed on
> the front page?
>
> [https://blog.rrwd.nl/2014/11/21/html5-headings-in-wordpress-lets-fight/
> Rian Rietveld writes]:
>
> > On the homepage the logo or site title can be put into an H1. '''This
> is not a link, because that will be a link to the page itself'''.
>
> And I think it makes perfect sense :)

New description:

 Hey!

 I have looked at the `get_custom_logo()` function recently and noticed
 that the logo is linked to home even if it is displayed on the front page.

 Wouldn’t it make sense to only link the logo if it is not displayed on the
 front page?

 [https://rianrietveld.com/2014/11/html5-headings-in-wordpress-lets-fight/
 Rian Rietveld writes]:

 > On the homepage the logo or site title can be put into an H1. '''This is
 not a link, because that will be a link to the page itself'''.

 And I think it makes perfect sense :)

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/37011#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list