[wp-trac] [WordPress Trac] #49635: Build tools: Remove generated and package sourced files from committed code.

[WordPress Trac]

#49635: Build tools: Remove generated and package sourced files from committed
code.
------------------------------+------------------------------
 Reporter:  peterwilsoncc     |       Owner:  (none)
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:                    |     Focuses:
------------------------------+------------------------------

Comment (by azaozz):

 Replying to [comment:4 SergeyBiryukov]:
 > As of [47471], I think it should be removed from the develop repo.

 Yes, `wp-includes/assets/script-loader-packages.php` can be SVN deleted,
 then added to `svn:ignore` and `.gitignore`. The same applies to `wp-
 includes/blocks/*.php`.


 The problems (as mentioned in [#comment:1 comment:1]) are:
 1. These files will be missing or will not get updated in `/src` when
 doing `npm run build` or `grunt build` or similar. This might trigger a
 PHP fatal when testing but seems pretty rare edge case.
 2. After the delete + ignore steps are committed, reverting to an earlier
 revision (where the files are still under version control) may result in
 SVN conflicts that could also trigger PHP fatal(s) in `/src`.

 Both of these seem like pretty rare edge cases, so can probably just "bite
 the bullet" and do it? :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49635#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform