[wp-trac] [WordPress Trac] #40969: RFE: get_template_part() to return something or warn when nothing found

WordPress Trac noreply at wordpress.org
Thu Jun 4 16:39:23 UTC 2020


#40969: RFE: get_template_part() to return something or warn when nothing found
-------------------------------------------------+-------------------------
 Reporter:  sphakka                              |       Owner:  (none)
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.5
Component:  Themes                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch dev-feedback needs-dev-    |     Focuses:  template
  note early has-unit-tests needs-testing        |
-------------------------------------------------+-------------------------
Changes (by tferry):

 * keywords:
     has-patch dev-feedback needs-unit-tests needs-dev-note early needs-
     refresh
     =>
     has-patch dev-feedback needs-dev-note early has-unit-tests needs-
     testing


Comment:

 Returning back to this ticket, I've realised I was mistaken in my previous
 comment - there are already tests on the previous patch (thanks
 @SergeyBiryukov, and apologies for missing them before).

 I've added some further tests that apply to the other `get_*()` functions
 that have been updated. As mentioned on a previous patch, testing the
 other functions for failure is unnecessary due to the theme-compat files
 (see comment:22).

 As such, I believe this is ready for testing, and possible inclusion in
 the next milestone, but any feedback is welcome.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/40969#comment:45>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list