[wp-trac] [WordPress Trac] #50280: Enable auto-updates shows for plugins with no support

[WordPress Trac]

#50280: Enable auto-updates shows for plugins with no support
------------------------------------+-----------------------------------
 Reporter:  elrae                   |       Owner:  audrasjb
     Type:  enhancement             |      Status:  accepted
 Priority:  normal                  |   Milestone:  5.5
Component:  Upgrade/Install         |     Version:  trunk
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  docs, administration
------------------------------------+-----------------------------------

Comment (by pbiron):

 Replying to [comment:6 azaozz]:
 > I'm having some second thoughts on
 `output_theme_auto_update_setting_template` though. It is the cleaner way
 of doing this, but that filter acts as both a filter and an action, which
 is unusual/may be a bit confusing. Also when more than one plugin is using
 the same filter, the last plugin to hook there wins, in this case the
 first plugin wins. Perhaps would be better to filter the template code as
 string after all, similarly to how the HTML filters work.

 Does this mean that the intention is that those hooking into it are
 supposed to `echo 'xyz'; return true;`

 If so, then yes, that is likely to cause developer confusion.  The
 DocBlock could be improved to make that more clear, it is **very** unusual
 that a filter directly results in output.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50280#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform