[wp-trac] [WordPress Trac] #49288: Metabox holders missing their border and "Drag boxes here" text

[WordPress Trac]

#49288: Metabox holders missing their border and "Drag boxes here" text
-------------------------------------+-------------------------------------
 Reporter:  xkon                     |       Owner:  audrasjb
     Type:  defect (bug)             |      Status:  reopened
 Priority:  highest omg bbq          |   Milestone:  5.5
Component:  Administration           |     Version:
 Severity:  blocker                  |  Resolution:
 Keywords:  has-patch has-           |     Focuses:  ui, accessibility,
  screenshots needs-testing needs-   |  administration
  backwards-compatibility            |
-------------------------------------+-------------------------------------
Changes (by azaozz):

 * keywords:  has-patch has-screenshots commit => has-patch has-screenshots
     needs-testing needs-backwards-compatibility
 * priority:  normal => highest omg bbq
 * status:  closed => reopened
 * resolution:  fixed =>
 * severity:  normal => blocker


Comment:

 Replying to [comment:52 afercia]:
 > I think the root problem is that your plugin uses the `post-body` ID for
 the meta box holders. Historically, the ID `post-body` is used in core to
 identify the edit pages of posts, comments, menu items. It's heavily used
 to target the core functionality.

 This is incorrect. The `#post-body` ID is used in core as a container for
 the writing area, and is reused by many plugins for the same purpose. A
 quick search shows that about 7,700 plugins reuse it:
 https://wpdirectory.net/search/01EE3JR3KJVSZFNR4R2MH6S8S0.

 In that terms the code committed here introduces a serious regression.

 Looking a bit deeper, why were some of the (older) default styles removed?
 They seem unrelated to this ticket:
 https://core.trac.wordpress.org/changeset/48340/trunk/src/wp-
 admin/css/common.css. Looks like there are 32,700 plugins that may be
 reusing some of these:
 https://wpdirectory.net/search/01EE3GHZPD2KPSS1J24KGXE4CB. Was this
 unrelated change even tested in any way?

 Considering the above two backwards compatibility problems (that seems
 easily avoidable), and the fact that the committed code reverts previous
 (long time ago) fix, thinking this should be reverted for 5.5, then fixed
 and committed in 5.6.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49288#comment:57>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform