[wp-trac] [WordPress Trac] #48780: Image Editor screen is scaled incorrectly

[WordPress Trac]

#48780: Image Editor screen is scaled incorrectly
-----------------------------------------+---------------------------------
 Reporter:  fierevere                    |       Owner:  (none)
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  5.4
Component:  Media                        |     Version:  5.3
 Severity:  normal                       |  Resolution:
 Keywords:  has-screenshots needs-patch  |     Focuses:  ui, administration
-----------------------------------------+---------------------------------
Changes (by afercia):

 * keywords:  has-screenshots has-patch needs-testing => has-screenshots
     needs-patch


Comment:

 Let's try to get this in 5.4 :)

 Re: [attachment:"48780.2.diff"]
 - Please avoid to introduce one more media query breakpoint at 783px. This
 value isn't used anywhere in core. We should try to use existing
 breakpoints. I'd rather reverse the logic and set min-width / max-width by
 default, then reset them at a the breakpoint max-width 782px
 - The bottom margin is changed to 20px. It's best to not introduce
 unrelated changes. If a change is worth it, then please mention in a
 comment in the ticket the reasons why.
 - In my testing, with a large image and the 2-columns layout, the float
 drop happens anyways with a viewport width around 1160 pixels. This is
 more or less what always happened. Further improvements should preferably
 go in #47136 where a larger refactoring is being considered.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48780#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform