[wp-trac] [WordPress Trac] #49291: Code issues with set_time_limit

[WordPress Trac]

#49291: Code issues with set_time_limit
--------------------------+------------------------------------------
 Reporter:  madpeter      |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Revisions     |     Version:  5.3.2
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  administration, performance
--------------------------+------------------------------------------
Changes (by SergeyBiryukov):

 * focuses:  performance => administration, performance
 * component:  Administration => Revisions
 * severity:  major => normal


Old description:

> file: wp-admin\includes\ajax-actions.php
> function: wp_ajax_get_revision_diffs
> line: 3425
> Issue: no time limit set
> Suggestion: set value to 120
>

> file: wp-includes\class-pop3.php
> function: __construct
> line: 63
> Issue: timeout value is not tested and can be set to 9999999 or a
> negitive value that acts the same as 0
> Suggestion: Force a range for the value (1 to 120)

New description:

 file: wp-admin\includes\ajax-actions.php
 function: `wp_ajax_get_revision_diffs`
 line: 3425
 Issue: no time limit set
 Suggestion: set value to 120


 file: wp-includes\class-pop3.php
 function: `__construct`
 line: 63
 Issue: timeout value is not tested and can be set to 9999999 or a negitive
 value that acts the same as 0
 Suggestion: Force a range for the value (1 to 120)

--

Comment:

 Hi there, welcome to WordPress Trac! Thanks for the report.

 * The `set_time_limit( 0 )` instance in `wp_ajax_get_revision_diffs()` was
 introduced in [24707] / #24757. Could you clarify why the value should be
 changed to 120?
 * Please note that `class-pop3.php` is a part of the PHPMailer external
 library, any changes to its files should be submitted upstream:
 https://github.com/PHPMailer/PHPMailer.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49291#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform