[wp-trac] [WordPress Trac] #49282: Cleanup Privacy .wp-policy-help CSS remnants (Broken back-compat)

WordPress Trac noreply at wordpress.org
Thu Jan 23 22:49:28 UTC 2020


#49282: Cleanup Privacy .wp-policy-help CSS remnants (Broken back-compat)
-----------------------------+-----------------------------
 Reporter:  garrett-eclipse  |      Owner:  (none)
     Type:  defect (bug)     |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  Privacy          |    Version:
 Severity:  normal           |   Keywords:  2nd-opinion
  Focuses:  css              |
-----------------------------+-----------------------------
 Hello,

 This comes from a discovery in #44588 that we updated the original `.wp-
 policy-help` class to be `.privacy-policy-tutorial` in
 [https://core.trac.wordpress.org/changeset/43184 Changeset#43184].

 There seems to be some remnant CSS in the TinyMCE CSS;
 https://github.com/WordPress/wordpress-
 develop/blob/6b366c6620fdd5960cedcdf80955966a715efa82/src/js/_enqueues/vendor/tinymce/skins/wordpress
 /wp-content.css#L268-L271

 One issue I've recently run into with the class change is it doesn't seem
 to have been properly disclosed to developers in a dev-note or otherwise
 so many plugins (such as WooCommerce,
 [https://github.com/woocommerce/woocommerce/blob/7701d4b57cb20dc89e25bb7bf2ff872d85f4c535/includes
 /class-wc-privacy.php#L71 example]) still utilize the old CSS class and as
 such their tutorial text is being copied along with the suggested text
 when the user goes to copy the section policy text.
 *wpdirectory.net is currently not listing names but indicates there's 52
 plugin matches and 3 theme matches.

 CC @azaozz - As the original committer I wanted your advice. Should we
 update the copy code to support both classes and as such all existing
 plugins, or maybe setup a dev-note or reach out to the plugin developers
 to prompt them to update and use the more appropriate `.privacy-policy-
 tutorial` class?

 Thank you

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49282>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list