[wp-trac] [WordPress Trac] #44264: Give progress indication for export and erasure

WordPress Trac noreply at wordpress.org
Wed Jan 22 22:26:07 UTC 2020


#44264: Give progress indication for export and erasure
----------------------------------------------+----------------------------
 Reporter:  allendav                          |       Owner:  garrett-
                                              |  eclipse
     Type:  enhancement                       |      Status:  accepted
 Priority:  normal                            |   Milestone:  5.4
Component:  Privacy                           |     Version:  4.9.6
 Severity:  normal                            |  Resolution:
 Keywords:  has-patch has-screenshots commit  |     Focuses:  ui,
                                              |  javascript
----------------------------------------------+----------------------------
Changes (by garrett-eclipse):

 * keywords:  has-patch has-screenshots needs-testing needs-design-feedback
     => has-patch has-screenshots commit


Comment:

 Thanks for testing @xkon and the refresh. The inline progress works
 nicely. In
 [https://core.trac.wordpress.org/attachment/ticket/44264/44264.5.diff
 44264.5.diff] I made a minor modification to condense the concatenations
 and avoid needing the standalone space before the span string, just merged
 the space into that string.

 I'm marking this for `commit` as it's testing nicely and we've got two
 maintainers approval here (myself & @xkon).

 I will note some minor issues with the UI which are addressed in other
 tickets.
 1) If you're using the row actions and move your cursor away the action
 vanishes and along with it the progress there. This would be resolved if
 progress can be made on #48751.
 *To illustrate this issue I made a GIF -
 https://i.gyazo.com/49b7f155fb15ce2795f906db417469cf.gif
 2) The progress on the button in some cases ends up with the percent split
 onto two lines so 5 followed by 0% on another line. This makes it hard to
 read. But is addressed in #46304 which introduces the break-word CSS.
 *To illustrate this issue I made a GIF -
 https://i.gyazo.com/fc9c9c7e57b069cc5f67717c92d75fb8.gif

 As confirmation of the patch below are some gifs of the various progress
 triggers;
 [Export][Row Action] Download Personal Data & Download Personal Data Again
 triggers - https://i.gyazo.com/cbcd703b8f149cbec9b335672568f1fc.gif
 [Export][Button] Send Export Email -
 https://i.gyazo.com/770ba41ff9aa4a16ec2b3bd272cc3ddb.gif
 [Erasure][Row Action] Force Erase Personal Data -
 https://i.gyazo.com/6058b038fd31b4c9bfb54d8352506353.gif
 [Erasure][Button] Erase Personal Data -
 https://i.gyazo.com/fc9c9c7e57b069cc5f67717c92d75fb8.gif

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44264#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list