[wp-trac] [WordPress Trac] #49196: Copy block metadata files for dynamic blocks

WordPress Trac noreply at wordpress.org
Wed Jan 22 22:17:30 UTC 2020


#49196: Copy block metadata files for dynamic blocks
-------------------------------------------------+-------------------------
 Reporter:  chipsnyder                           |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  5.4
Component:  Build/Test Tools                     |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch 2nd-opinion needs-testing  |     Focuses:  javascript
-------------------------------------------------+-------------------------
Changes (by azaozz):

 * keywords:  has-patch => has-patch 2nd-opinion needs-testing


Comment:

 Quick look at 49196-block-folders_updated.diff: (Mass) renaming/moving of
 existing PHP files seems very risky. Is there a chance that a plugin may
 be doing something like `require_once( ABSPATH . WPINC . '/blocks/latest-
 posts.php' );` and moving that file would "bring the site down" with a PHP
 fatal error? Is it possible to avoid the moving and renaming?

 This concerns mostly the "build tools" as far as I understand. Don't think
 it is a good idea to change existing files to accommodate changes to how
 the building is done. Rather the build process should be accommodating the
 existing files.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49196#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list