[wp-trac] [WordPress Trac] #51056: Fetch_feed parsing of permalinks triggers simplepie preg_match warnings

[WordPress Trac]

#51056: Fetch_feed parsing of permalinks triggers simplepie preg_match warnings
-------------------------------------------+-----------------------
 Reporter:  litemotiv                      |       Owner:  iandunn
     Type:  defect (bug)                   |      Status:  closed
 Priority:  high                           |   Milestone:  5.6.1
Component:  External Libraries             |     Version:  5.5
 Severity:  critical                       |  Resolution:  fixed
 Keywords:  php8 has-patch has-unit-tests  |     Focuses:  rest-api
-------------------------------------------+-----------------------
Changes (by iandunn):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"49806" 49806]:
 {{{
 #!CommitTicketReference repository="" revision="49806"
 Feed: Merge multiple header values to avoid fatal error.

 When SimplePie parses HTTP headers, it combines multiple values for the
 same header into a comma-separated string. `WP_SimplePie_File` overrides
 the parsing, but was leaving them as an array instead.

 That lead to a fatal error in PHP 8, because other parts of the codebase
 ended up passing an array to a function that expected a string.

 Props david.binda, litemotiv, inc2734, NicolasKulka, hellofromTonya,
 mbabker, skithund, SergeyBiryukov, desrosj, timothyblynjacobs.
 Reviewed by SergeyBiryukov, iandunn.
 Merges [49803] and [49805] to the 5.6 branch.
 Fixes #51056. See #51956.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51056#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform