[wp-trac] [WordPress Trac] #47797: Provide compatible core update for users not on PHP >= 5.6

[WordPress Trac]

#47797: Provide compatible core update for users not on PHP >= 5.6
-------------------------------------------+----------------------------
 Reporter:  afragen                        |       Owner:  (none)
     Type:  enhancement                    |      Status:  closed
 Priority:  normal                         |   Milestone:  WordPress.org
Component:  Site Health                    |     Version:
 Severity:  normal                         |  Resolution:  fixed
 Keywords:  has-patch needs-testing early  |     Focuses:
-------------------------------------------+----------------------------
Changes (by dd32):

 * status:  new => closed
 * resolution:   => fixed
 * milestone:  5.4 => WordPress.org


Comment:

 I've fixed this through an API change, a little used functionality in Core
 allows the API to return multiple update offerings which the user can
 choose between. I'm fairly sure it was added for this exact scenario
 happening at some point in the future.

 Re-using/re-branding the `autoupdate` responses as done in the attachments
 here isn't recommended, as it has the potential to use the wrong packages.

 I'll copy the [https://meta.trac.wordpress.org/ticket/4699 Meta comment]
 here:

 Replying to [comment:16 dd32]:
 > I've made an API change which returns multiple versions for users on
 WordPress 3.7~5.1 running PHP 5.2.4~5.6.20.
 >
 > We can make a similar addition for when PHP 5.6 support is dropped (It
 won't be automatic, as I hard-coded the PHP and WP versions)
 >
 > The above attachment shows the experience, it's not ''fantastic''
 especially as the string in core doesn't expect that this could ever
 occur.
 > I figured showing both would at least allow the user to update to a
 recent WordPress, while at the same time also making it clear there's a
 newer version of WordPress that has a more modern PHP requirement.
 >
 > Fixed via r15417-dotorg:
 > {{{
 > API: Core Update endpoint: Offer WordPress 5.1.x as an update
 destination for < 5.1.latest and PHP 5.2.4~5.6.19 users.
 > }}}

 The attachment being referred to above is the following, which is the
 experience for a WordPress 4.9 user running PHP 5.3 following this change,
 previously they'd have just seen the first "You cannot update because ..."
 message.

 [[Image(https://meta.trac.wordpress.org/raw-
 attachment/ticket/4699/Screen%20Shot%202019-10-17%20at%2012.33.30%20pm.png)]]

 I'm going to mark this as fixed, but feel free to re-open if there's
 something further wanted to be done in core here. If you'd like the API
 changed, please @mention me on the Meta ticket above :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47797#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform