[wp-trac] [WordPress Trac] #47069: Twenty Nineteen: the admin bar on the front end has reduced functionalities and bugs due to jQuery not being used

WordPress Trac noreply at wordpress.org
Wed Oct 2 15:40:45 UTC 2019


#47069: Twenty Nineteen: the admin bar on the front end has reduced functionalities
and bugs due to jQuery not being used
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:  audrasjb
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  5.3
Component:  Toolbar                  |     Version:  5.0
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  accessibility,
  patch                              |  javascript
-------------------------------------+-------------------------------------
Changes (by afercia):

 * keywords:  has-screenshots has-patch needs-testing commit => has-
     screenshots has-patch


Comment:

 [attachment:"47069.7.diff"] takes the minimal approach and just enqueues
 jQuery as dependency of `admin-bar`.

 For the future WP 5.4, the accessibility team strongly recommends
 refactoring `admin-bar` in plain JavaScript and make this ticket a task.
 For now, at this point of the 5.3 release, the minimal approach seems the
 only wise option.

 This adds ~105 KB (minified but not gzipped) to the front end. Of course
 only when logged in and the user preference "Show Toolbar when viewing
 site" is on. Of course, theme that already use jQuery won't see any
 difference.

 Worth reminding that for themes that don't use jQuery some of the
 functionalities of the admin bar aren't working. For example: hoverintent
 and, most notably, the admin bar menu on mobile is broken. It always
 worked this way, maybe because a few years ago it was pretty common for
 themes to always use jQuery.

 Today, more and more themes don't use jQuery.

 Twenty Nineteen and also the new Twenty Twenty don't. Also other teams in
 the ecosystem are more and more "jQuery free": I tested a few themes from
 **2016** and since they don't use jQuery, the admin bar is not fully
 functional.

 In light of the release of Twenty Twenty this issue seems pretty urgent.
 I'd propose to bring this ticket to the attention of a larger audience
 during [https://make.wordpress.org/core/2019/10/02/dev-chat-agenda-for-
 october-2nd-2019-5-3-week-7/ today's dev chat on Slack].

 pinging @francina as 5.3 Release Coordinator
 pinging @davidakennedy and @laurelfulford as maintainers of the Bundled
 Theme component
 pinging @azaozz as 5.3 Core Tech focus lead
 pinging @ianbelanger as 5.3 Default Theme Wrangler
 pinging @anlino as 5.3 Default Theme Designer

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47069#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list