[wp-trac] [WordPress Trac] #48648: Inconsistent length of .action-links DIV in plugin card

WordPress Trac noreply at wordpress.org
Wed Nov 20 07:03:14 UTC 2019


#48648: Inconsistent length of .action-links DIV in plugin card
-------------------------------------------------+-------------------------
 Reporter:  kharisblank                          |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.4
Component:  Plugins                              |     Version:  5.3
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots good-first-bug has-  |     Focuses:  ui,
  patch                                          |  administration
-------------------------------------------------+-------------------------

Comment (by kharisblank):

 Hello @sabernhardt,

 Thank you for testing it. You are right, my first patch has a lot of
 weakness.

 If we could use ellipsis on longer primary action button text on other
 language, here's CSS code correction I would like to suggest.


 {{{
 .plugin-action-buttons {
         min-width: 120px;
 }

 .plugin-action-buttons a {
         max-width: 120px;
         display: inline-block;
         overflow: hidden;
         text-overflow: ellipsis;
 }
 }}}

 > So we can consider adding a comment for translators, which would
 recommend shorter length.

 If ellipsis would make it worse, all translators should correct and use
 shorter text.

 Best,
 Kharis

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48648#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list