[wp-trac] [WordPress Trac] #48598: :active button color issue when Midnight color scheme has been selected

WordPress Trac noreply at wordpress.org
Mon Nov 18 15:48:11 UTC 2019


#48598: :active button color issue when Midnight color scheme has been selected
-------------------------------------------------+-------------------------
 Reporter:  studiotwee                           |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.3.1
Component:  Administration                       |     Version:  5.3
 Severity:  normal                               |  Resolution:
 Keywords:  5-3-admin-css-changes has-patch      |     Focuses:  ui,
  has-screenshots needs-design-feedback          |  accessibility
-------------------------------------------------+-------------------------
Changes (by afercia):

 * keywords:  5-3-admin-css-changes has-patch has-screenshots => 5-3-admin-
     css-changes has-patch has-screenshots needs-design-feedback


Comment:

 Thanks for the patch @larrach 👋

 I'm not sure the background color change should be kept though. That was a
 mistake introduced in

 Instead, I'd tend to think the `:active` style should be consistent with
 the Gutenberg one. There's an inconsistency in Gutenberg as well, as the
 style varies across the color schemes. I just created an issue, thinking
 there should be some quick design feedback. See
 https://github.com/WordPress/gutenberg/issues/18577

 Note: I think we can't use a new variable, as alternate color schemes
 provided by plugins would miss the variable. To test, install this plugin:
 https://wordpress.org/plugins/admin-color-schemes/

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48598#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list