[wp-trac] [WordPress Trac] #40439: Save progress of intermediate image creation after upload

[WordPress Trac]

#40439: Save progress of intermediate image creation after upload
-------------------------------------------------+-------------------------
 Reporter:  mikeschroder                         |       Owner:
                                                 |  mikeschroder
     Type:  enhancement                          |      Status:  assigned
 Priority:  high                                 |   Milestone:  5.3
Component:  Media                                |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-unit-  |     Focuses:  ui
  tests early                                    |
-------------------------------------------------+-------------------------

Comment (by birgire):

 Great addition that will hopefully help many users.

 Regarding

 > Note that the patch also includes some unrelated WPCS fixes.

 I noticed the patch changes:

 {{{
 true == ini_get( 'allow_url_fopen' )

 }}}

 to:

 {{{
 true === ini_get( 'allow_url_fopen' )

 }}}

 I tested the output of {{{ini_get( 'allow_url_fopen' )}}} on my test
 install

 When I define in php.ini:

 {{{
 allow_url_fopen = On

 }}}

 or

 {{{
 allow_url_fopen = 1

 }}}

 or

 {{{
 allow_url_fopen = true

 }}}

 the output is the string {{{'1'}}}.

 When I define it as:

 {{{
 allow_url_fopen = Off

 }}}

 or

 {{{
 allow_url_fopen = 0

 }}}

 or

 {{{
 allow_url_fopen = false

 }}}

 the output is the empty string {{{''}}}.

 So it seems the new strict {{{true}}} check will not work as the previous
 check did.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/40439#comment:43>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform