[wp-trac] [WordPress Trac] #47014: Tag balancing corrupts Custom Elements

[WordPress Trac]

#47014: Tag balancing corrupts Custom Elements
--------------------------------------+------------------------
 Reporter:  westonruter               |       Owner:  flixos90
     Type:  defect (bug)              |      Status:  reviewing
 Priority:  normal                    |   Milestone:  5.3
Component:  Formatting                |     Version:  2.0.4
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------

Comment (by birgire):

 Good point @dmsnell regarding the extra maintenance burden of having the
 regex pattern duplicated.

 Having an easy way to remove the comments from the regex pattern, e.g.
 from the PHP shell example you provided, sounds good to me, if one needs
 to test it further with regex tools.

 For the tests in [attachment:"47014-4.diff"] I would suggest :

 - adding {{{@ticket 47014}}} annotation to new {{{test_}}} methods
 - {{{@since 5.3.0}}} annotation to new non {{{test_}}} methods.
 - adding some missing end of line dots (also in tests)
 - e.g. use {{{@see}}} annotation in the comment: {{{// see http...}}}.

 PS: also few missing end of line dots, both in code comments and tests
 comments.

 All the best

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47014#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform