[wp-trac] [WordPress Trac] #47458: Fix tab sequence order in the Media attachment browser

[WordPress Trac]

#47458: Fix tab sequence order in the Media attachment browser
---------------------------------------+----------------------------
 Reporter:  afercia                    |       Owner:  (none)
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  5.3
Component:  Media                      |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:  accessibility
---------------------------------------+----------------------------
Changes (by afercia):

 * keywords:  needs-patch has-screenshots => has-screenshots has-patch


Comment:

 Problem :
 - the Close button comes from the media modal template thus the CLose
 button is first in the DOM order
 - then, the edit-attachments view adds the Previous and Next buttons:
 they're after in the DOM source and absolutely positioned to make them
 appear before the Close button
 - these elements can't be rearranged because they pertain to different
 views

 [attachment:"47458.diff"]:
 - makes the modal Close button optional via a `hasCloseButton` property,
 default: true
 - makes the edit-attachments template use its own Close button so it can
 be placed in the right order
 - no visual changes

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47458#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform