[wp-trac] [WordPress Trac] #45968: extend get_search_form() to allow placeholder text to be passed into method

[WordPress Trac]

#45968: extend get_search_form() to allow placeholder text to be passed into method
-------------------------------------------------+-------------------------
 Reporter:  gege90ererefeee                      |       Owner:  (none)
     Type:  feature request                      |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Themes                               |     Version:
 Severity:  minor                                |  Resolution:
 Keywords:  has-patch 2nd-opinion reporter-      |     Focuses:
  feedback                                       |  accessibility
-------------------------------------------------+-------------------------
Changes (by afercia):

 * keywords:  has-patch 2nd-opinion => has-patch 2nd-opinion reporter-
               feedback


Comment:

 Worth noting this function prints out also a visually hidden label for the
 search input:

 {{{
 <label>
         <span class="screen-reader-text">' . _x( 'Search for:', 'label' )
 . '</span>
         ...
 }}}

 When changing the placeholder, the visually hidden label should still make
 sense, which makes things a bit more complicated.

 @gege90ererefeee any more use cases other than having the ability to
 change `Search...` to `Search here..`?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45968#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform