[wp-trac] [WordPress Trac] #48885: REST API: Add a route to read and update separate site settings

WordPress Trac noreply at wordpress.org
Wed Dec 11 03:23:25 UTC 2019


#48885: REST API: Add a route to read and update separate site settings
--------------------------------------------------+---------------------
 Reporter:  scruffian                             |       Owner:  (none)
     Type:  enhancement                           |      Status:  new
 Priority:  normal                                |   Milestone:  5.4
Component:  REST API                              |     Version:
 Severity:  normal                                |  Resolution:
 Keywords:  has-patch has-unit-tests 2nd-opinion  |     Focuses:
PR Number:                                        |
--------------------------------------------------+---------------------
Changes (by pento):

 * keywords:   => has-patch has-unit-tests 2nd-opinion
 * milestone:  Awaiting Review => 5.4


Comment:

 @scruffian: Nice work exploring this!

 I'm pondering whether we really need to register a new route here:
 instead, the existing route can just return particular settings based on
 whether the current user has read access to all settings, or just those
 marked public.

 [attachment:"48885.diff"] is an experiment along those lines, what do you
 think of this direction?

 @TimothyBlynJacobs, do you have thoughts here? You mentioned concerns over
 on GB18760 with exposing read-only access to the entire settings API to
 non-admins, which I agree is a non-starter. Restricting which settings
 show to non-admins seems like it would cover this problem, however.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48885#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list